Update common to v3.2.1 to fix gotestsum cmd

Adam Cohenrequested to merge
adamcohen/bulk-upgrade-common-package-to-fix-failing-gotestsum-command into master

What does this MR do?

Add junit report for Go tests (gitlab-org/security-products/ci-templates!326 - merged) added gotestsum to the go test job, which has resulted in failures in the job output:

=== FAIL: . TestFindProjects/nonproject (unknown)
DONE 24 tests, 6 failures in 29.056s

These failures do not cause the go test job to fail, however, they cause gotestsum to incorrectly populate the MR test widget with false positive failures:

The root cause of the issue is that gotestsum is interpreting coloured log output which has been formatted by common/logutil/format.go as a failure, as described here.

This behaviour has been fixed in v3.2.1 of the common package in Do not color newline in log messages (common!163 - merged).

This MR updates the version of the common package to v3.2.1 to fix this issue and remove false-positives from the MR test widget.

What are the relevant issue numbers?

Fix coloured log output in logutil package of s... (gitlab-org/gitlab#375625 - closed)

Testing

After this change, the go test job passes:

$ gotestsum --junitfile report.xml --format testname -- -race -coverprofile=coverage.txt -covermode atomic ./...
PASS TestFindSolution (0.00s)

coverage: 89.7% of statements
PASS project (coverage: 89.7% of statements)
DONE 24 tests in 27.658s

and the MR test widget now reports all tests passing:

Does this MR meet the acceptance criteria?

Edited by Adam Cohen

Merge request reports