Skip to content

Fix buffer overflow on large files

Lucas Charles requested to merge 10281-fix-buffer-overflow-on-large-files into master

What does this MR do?

Replaces !6 (closed)

Replace bufio.Scanner usage with bufio.Reader to handle large file buffers exceeding 64kb.

❯ time docker run --rm --volume /Users/theoretick/code/tmp/gitlab-ee/:/tmp/project --env CI_PROJECT_DIR=/tmp/project analyzer /analyzer run

real	7m52.678s
user	0m0.047s
sys	0m0.026s

This also uncovered an inconsistency introduced with !5 (merged) where the rulename was incorrect: RKCS8 should be PKCS8

No description for Gitleaks rule PKCS8, please open an issue on https://gitlab.com/gitlab-org/gitlab-ee/issues

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ee/issues/10281

Does this MR meet the acceptance criteria?

Edited by Fabien Catteau

Merge request reports