Skip to content

Ensure keywords are case-sensitive

James Liu requested to merge jliu-case-sensitive-keywords into master

What does this MR do?

Modifies the keywords array of well-known patterns so they have a case-sensitive match to the beginning of the key. This should have no effect on the scanner as Gitleaks normalises the input fragment as well as the keywords before performing the string comparison. It will have an impact however in the performance of gitlab-org/gitlab#376716 (closed), as string lowercasing can be a wasteful operation.

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Edited by Vishwa Bhat

Merge request reports