Fix historic scan bug
What does this MR do?
Fixes a bug where we used c.IsSet(SECRET_DETECTION_HISTORIC_SCAN) to check if an historic scan should be kicked off rather than extracting the value using c.Bool(SECRET_DETECTION_HISTORIC_SCAN)
- SECRET_DETECTION_HISTORIC_SCAN not set: https://gitlab.com/zrice/demo-historic-bug/-/jobs/2923774299
- SECRET_DETECTION_HISTORIC_SCAN explicitly set to true: https://gitlab.com/zrice/demo-historic-bug/-/jobs/2923779778
- SECRET_DETECTION_HISTORIC_SCAN explicitly set to false: https://gitlab.com/zrice/demo-historic-bug/-/pipelines/620934796
What are the relevant issue numbers?
gitlab-org/gitlab#331798 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated for GitLab EE, if necessary -
Documentation created/updated for this project, if necessary -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Job definition updated, if necessary -
Conforms to the code review guidelines -
Conforms to the Go guidelines -
Security reports checked/validated by reviewer
Edited by Lucas Charles