Add support for HTTPS proxies
What does this MR do?
Pass the value of HTTPS_PROXY
to the retire
command, using the --proxy
CLI option. This is needed because retire
doesn't read that variable, and proxies can only be set via --proxy
.
HTTPS_PROXY
isn't exposed a CLI flag using urfave/cli
. If we do that, it's removed from the environment but the npm
needs it. We could work around that problem by calling npm config set http-proxy
, but that would increase the complexity of the code with no significant benefit.
The value of HTTPS_PROXY
is printed to the log.
HTTP_PROXY
isn't supported because:
- It's not safe.
- It would require a specific integration test.
This is the maintainer copy of !67 (closed).
What are the relevant issue numbers?
gitlab-org/gitlab#232818 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated for GitLab EE, if necessary -
Documentation created/updated for this project, if necessary -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Job definition updated, if necessary -
Conforms to the code review guidelines -
Conforms to the Go guidelines -
Security reports checked/validated by reviewer
Edited by Fabien Catteau