Skip to content

Force location to package.json, ignore node_modules, when installing dependencies

Fabien Catteau requested to merge 13827-fix-location-node_modules into master

What does this MR do?

  • Force vulnerability location to package.json when reported location is node_modules, and dependencies have been installed during the scan by running npm install or yarn install. This fixes broken links to missing node_modules directory in GitLab UI.
  • Add a QA job for this, using the new node_modules branch of the tests/js-npm project
  • Upgrade common library
  • Fix indentation of GitLab CI file

The analyze function communicates with the convert function using an environment variable because convert must match the ConvertFunc type defined in the common library, so it's not possible to pass extra arguments.

What are the relevant issue numbers?

gitlab-org/gitlab#13827 (closed)

Does this MR meet the acceptance criteria?

Edited by Fabien Catteau

Merge request reports