Skip to content

fix: Ruleset disablement of secondary identifier should filter primaries

What does this MR do?

Previously, disabling a primary identifier would filter scan.PrimaryIdentifiers but disabling a non-primary identifier would not properly filter the PrimaryIdentifier collection.

This also fixes a previous assertion removed in gitlab-org/gitlab#398809 (closed)

3 Minor cleanup tasks:

  • Remove unneeded configuration from sast-ruleset-disable-ids.toml
  • Switch from custom SetFeatureEnv func to t.Setenv
  • Add missing names to TestDisableIdentifierReports testcases

What are the relevant issue numbers?

Follow-up to gitlab-org/gitlab#398809 (closed)

Does this MR meet the acceptance criteria?

Edited by Lucas Charles

Merge request reports