Skip to content

Update common to v3.2.1 to fix gotestsum cmd

Adam Cohen requested to merge fix-failing-gotestsum-command into main

What does this MR do?

Add junit report for Go tests (gitlab-org/security-products/ci-templates!326 - merged) added gotestsum to the go test job, which has resulted in failures in the job output:

=== FAIL: . TestToolExecutionNotifications/testdata/reports/semgrep_js_syntax_error.sarif (unknown)
[WARN] [2022-09-23T17:29:28Z] ▶ tool notification warning: Syntax error Semgrep Core WARN - Syntax error: When running eslint.detect-non-literal-require on /builds/gitlab-com/gl-security/engineering-and-research/gib/reports/theme/static/js/chart.js: `5:` was unexpected

These failures do not cause the go test job to fail, however, they cause gotestsum to incorrectly populate the MR test widget with false positive failures:

The root cause of the issue is that gotestsum is interpreting coloured log output which has been formatted by common/logutil/format.go as a failure, as described here.

This behaviour has been fixed in v3.2.1 of the common package in Do not color newline in log messages (common!163 - merged).

This MR updates the version of the common package to v3.2.1 to fix this issue and remove false-positives from the MR test widget.

What are the relevant issue numbers?

Fix coloured log output in logutil package of s... (gitlab-org/gitlab#375625 - closed)

Does this MR meet the acceptance criteria?

Edited by Lucas Charles

Merge request reports