Add integration test Spec
What does this MR do?
To bring this project inline with the other analyzers, this MR adds an RSpec integration test to ensure the scanner is working as expected.
What are the relevant issue numbers?
This MR relates to but is not required by gitlab-org/gitlab#373921 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated for GitLab EE, if necessary -
Documentation created/updated for this project, if necessary -
Documentation reviewed by technical writer or follow-up review issue created -
Tests updated/added for this feature/bug -
Job definition updated, if necessary -
Conforms to the code review guidelines -
Conforms to the Go guidelines -
Security reports checked/validated by reviewer
Merge request reports
Activity
changed milestone to %16.3
added Category:SAST devopssecure groupstatic analysis labels
assigned to @craigmsmith
added sectionsec label
2 Warnings This merge request is quite big (568 lines changed), please consider splitting it into multiple merge requests. 2d1d2666: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer Ahmed Hemdan (
@ahmed.hemdan
) (UTC+2, 8 hours behind@craigmsmith
)James Liu (
@jamesliu-gitlab
) (UTC+10, same timezone as@craigmsmith
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded maintenancetest-gap typemaintenance labels
added 1 commit
- ad11ad82 - Remove old expected JSON, does anything break?
added 1 commit
- 171144fd - Remove old QA as they don't seen to do anything
- Resolved by James Liu
requested review from @ahmed.hemdan
- Resolved by James Liu
@ahmed.hemdan could you take a look at this MR please.
- Resolved by Ahmed Hemdan
added 2 commits
requested review from @jamesliu-gitlab
removed review request for @ahmed.hemdan
mentioned in commit 1c802609