Use pinned repo for asdf-nodejs
What does this MR do?
This MR uses a forked version of asdf-nodejs
using a revision before the plugin started using an unbound variable ASDF_DOWNLOAD_PATH
. See issue for more info.
Here is the license_scanning job failing:
- job: https://gitlab.com/gitlab-org/security-products/tests/js-npm/-/jobs/1973230861#L40
- report generated: https://gitlab-org.gitlab.io/-/security-products/tests/js-npm/-/jobs/1973230861/artifacts/gl-license-scanning-report.json
Here it is passing (using docker image built in this MR):
- job: https://gitlab.com/gitlab-org/security-products/tests/js-npm/-/jobs/1973401878
- report: https://gitlab-org.gitlab.io/-/security-products/tests/js-npm/-/jobs/1973401878/artifacts/gl-license-scanning-report.json
What are the relevant issue numbers?
gitlab-org/gitlab#349883 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated for GitLab EE, if necessary -
Documentation created/updated for this project, if necessary -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Job definition updated, if necessary -
Job definition example -
CI Templates (to be removed) -
Vendored CI Templates (also in CE) -
Ensure that all of the ENV vars supported are propagated to Docker containers upon docker run
in job definitions
-
-
Conforms to the code review guidelines -
Security reports checked/validated by reviewer
Edited by Igor Frenkel