Handle exit status
What does this MR do?
The documented kics exit codes are not the only ones that we may receive, but they are the only ones that we handled. This caused us to not log failure to the job logs in some instances. This made it harder to troubleshoot (turning on debug did show them).
With this MR, all errors that cause the analyzer to crash should be logged.
Minimal demonstration of problem: rossfuhrman/malformed_terraform!1 (closed)
- Output before change: https://gitlab.com/rossfuhrman/malformed_terraform/-/jobs/2651994750
- Output after change: https://gitlab.com/rossfuhrman/malformed_terraform/-/jobs/2652041378
What are the relevant issue numbers?
Improve kics analyzer logging to debug ongoing ... (gitlab-org/gitlab#358604 - closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated for GitLab EE https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10527 -
Documentation created/updated for this project, if necessary -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Job definition updated, if necessary -
Conforms to the code review guidelines -
Conforms to the Go guidelines -
Security reports checked/validated by reviewer
Edited by Lucas Charles