Skip to content

Ignore fields with :SKIP: when comparing JSON

Adam Cohen requested to merge 336332-ignore-fixtures-with-skip-fields into main

What does this MR do?

  1. Use include_json(expected) instead of eql(expected) when comparing JSON.

  2. Monkeypatch the RSpec::JsonExpectations gem so it returns true when comparing fields containing the string :SKIP:.

  3. Remove sorting in the GitlabSecure::IntegrationTest::Comparable module from the following fields:

    • vulnerabilities
    • dependency_files
    • dependencies
    • remediations

    Sorting has been removed from these fields because it's already implemented in the report package.

What are the relevant issue numbers?

Update integration-test project to skip fields ... (gitlab-org/gitlab#336332 - closed)

Testing

Edited by Adam Cohen

Merge request reports