refactor: tighten up maven-plugin-builder pom for approachibility and maintenance
What does this MR do?
Tightens up the build/gemnasium-maven/utils/maven-plugin-builder/pom.xml
. This is includes refactoring plugin versions to properties to make maintenance and updates easier, including taking advantage of DRY, i.e., update the plexus-utils
version in one spot. Remove the plugins declared as dependencies (this is a common misunderstanding of the difference between a dependency
(classpath) and plugin
(functionality). Move all plugins to project build pluginManagement
for maintenance approachability. This may also incrementally improve the build times.
What are the relevant issue numbers?
gitlab-org/gitlab#414890 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated for GitLab EE, if necessary -
Documentation created/updated for this project, if necessary -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Job definition updated, if necessary -
Conforms to the code review guidelines -
Conforms to the Go guidelines -
Security reports checked/validated by reviewer
Edited by Timothy Stone