Skip to content
Snippets Groups Projects

Vrange CLI for npm

Merged Fabien Catteau requested to merge 14630-vrange-npm into 14630-use-gemnasium-db
All threads resolved!

What does this MR do?

Add a vrange-compatible CLI to check node-semver (npm) versions, and tell if there are in range.

Related issues

gitlab-org/gitlab#14630 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Fabien Catteau assigned to @adamcohen and unassigned @fcatteau

    assigned to @adamcohen and unassigned @fcatteau

  • Author Maintainer

    I'll probably rebase after merging !41 (merged), if things go as expected.

  • Julian Thome added 1 commit

    added 1 commit

    Compare with previous version

  • I applied some adjustments to produce the output according to our protocol. I will also add some test cases.

  • Julian Thome added 1 commit

    added 1 commit

    • 9a2e93e2 - tests cases; renamed file to rangecheck.js

    Compare with previous version

  • Julian Thome added 1 commit

    added 1 commit

    Compare with previous version

  • Julian Thome unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Julian Thome changed title from WIP: vrange CLI for npm to Vrange CLI for npm

    changed title from WIP: vrange CLI for npm to Vrange CLI for npm

  • Julian Thome changed the description

    changed the description

  • Julian Thome assigned to @fcatteau and unassigned @adamcohen

    assigned to @fcatteau and unassigned @adamcohen

  • Julian Thome added 1 commit

    added 1 commit

    Compare with previous version

  • Fabien Catteau
  • Author Maintainer

    @julianthome Great! Thanks a lot! I've got a question about the tests, and fs.js has to be replaced with rangecheck.js in a few files. Back to you! :ping_pong:

  • Fabien Catteau assigned to @julianthome and unassigned @fcatteau

    assigned to @julianthome and unassigned @fcatteau

  • Fabien Catteau mentioned in merge request !25 (merged)

    mentioned in merge request !25 (merged)

  • Julian Thome added 1 commit

    added 1 commit

    • 319f69ad - Apply suggestion to vrange/npm/README.md

    Compare with previous version

  • Julian Thome added 1 commit

    added 1 commit

    • 3819aed9 - Apply suggestion to vrange/npm/README.md

    Compare with previous version

  • Julian Thome added 1 commit

    added 1 commit

    • f2e5f8d4 - Apply suggestion to vrange/npm/README.md

    Compare with previous version

  • Julian Thome added 2 commits

    added 2 commits

    • 0e165d5b - add checks for exit code
    • 53ca5a35 - Merge branch '14630-vrange-npm' of...

    Compare with previous version

  • Julian Thome added 1 commit

    added 1 commit

    • 76590938 - compute script name dynamically

    Compare with previous version

  • Julian Thome resolved all threads

    resolved all threads

  • Julian Thome assigned to @fcatteau and unassigned @julianthome

    assigned to @fcatteau and unassigned @julianthome

  • Thanks Fabien. I addressed the comments mentioned above. Back to you :ping_pong:

  • Author Maintainer

    @adamcohen Could you approve this? It looks like I can't because I contributed the initial import. :laughing:

  • Fabien Catteau assigned to @adamcohen and unassigned @fcatteau

    assigned to @adamcohen and unassigned @fcatteau

  • Adam Cohen approved this merge request

    approved this merge request

  • Fabien Catteau mentioned in commit 7d5446dc

    mentioned in commit 7d5446dc

  • 🤖 GitLab Bot 🤖 changed the description

    changed the description

  • GitLab Dependency Bot mentioned in merge request !504 (closed)

    mentioned in merge request !504 (closed)

  • GitLab Dependency Bot mentioned in merge request !508 (closed)

    mentioned in merge request !508 (closed)

  • Please register or sign in to reply
    Loading