Implement parser for pipfile.lock
What does this MR do?
Introduce dependency file parser for Pipfile.lock.
The parser is NOT enabled/imported in main.go because this is currently blocked by gitlab-org/gitlab#33341 (closed).
Also, this parser is redundant with Pipfile parser, enabled in gemnasium-python (see pipenv.go).
What are the relevant issue numbers?
gitlab-org/gitlab#33227 (closed)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the Go guidelines -
Security reports checked/validated by reviewer -
Remove main.go line 31 after MR is accepted -
Revert changes in .gitlab-ci.ymlafter MR is accepted. Changes are just for testing purposes
Merge request reports
Activity
assigned to @caneldem
-
@caneldem It looks like you've implemented the
Pipfile.lockparser, which is all we can do at the moment anyways, because of gitlab-org/gitlab#33341 (closed). Shall I review this? Is it still WIP?In the meantime I'm assigning the MR to you, to make sure it doesn't get lost.
UPDATE: I did a quick review but didn't check every single line of code.
changed milestone to %12.4
@fcatteau its ready for review thanks for early feedback.
- Remove main.go line 31 after MR is accepted
-
Revert changes in
.gitlab-ci.ymlafter MR is accepted. Changes are just for testing purposes
-
@caneldem Back to you!
added 1 commit
- fbca8312 - Add missing test and apply feedback for refactor
-
- changed struct for parsing
- added filter for pypi and empty fields
- added condition for pipfile-spec field (see discussion above)
changed milestone to %12.5
-
@caneldem Sorry for the delay. Back to you!
added 43 commits
-
fbd97c0a...6024edbf - 37 commits from branch
master - 89bd4ee8 - Add support for pipfilelock
- 6479c9c2 - Fix test
- f3372373 - Better structures for parsing
- ad53a614 - Accept packages from pypi and unknown
- dc6d76ba - Merge branch 'add-pipfilelock' of...
- 9c665ac3 - Ignore pipfilespec and use index if exists
Toggle commit list-
fbd97c0a...6024edbf - 37 commits from branch