Ensure git safe.directory command does not overwrite existing entries

Adam Cohenrequested to merge
571828-make-git-safe-directory-additive into master

What does this MR do?

Makes the safe.directory command additive.

  • Before this change:

    Integration test fails:

      2) running image with test project with js-npm with lockfile v1 issue-571828 behaves like successful scan exit code is expected to eq 0
     Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { |failure, _opts| raise failure }
       expected: 0
            got: 1280

  • After this change:

    Integration test succeeds

What are the relevant issue numbers?

gemnasium safe directory git command overwrites... (gitlab-org/gitlab#571828 - closed) • Adam Cohen • 18.5

Does this MR meet the acceptance criteria?

Closes #571828

Edited by Adam Cohen

Merge request reports