Skip to content

Add Pipfile.lock support

Fabien Catteau requested to merge 11756-pipfile-lock into master

What does this MR do?

Enable file parser for Pipfile.lock

Backward compatibility is maintained, and gemnasium-python is still able to scan a Pipenv project that has no lock file.

Warning! This change has two significant side-effects:

  • location of the vulnerabilities changes. See diff in failing QA job. Vulnerability feedback will be lost.
  • The report contains the normalized names of the dependencies (those stored in Pipfile.lock), and not the canonical names. This affects the Dependency List but not dependency scanning itself.

Users can delete Pipfile.lock prior to running the scan (in the before_script) to restore the previous behavior. In the future, they might be able to achieve the same using DS_EXCLUDED_PATHS, after implementing gitlab-org/gitlab#292457 (closed).

What are the relevant issue numbers?

gitlab-org/gitlab#11756 (closed)

Does this MR meet the acceptance criteria?

Edited by Fabien Catteau

Merge request reports