Fix: CLI flags for pip builder are ignored
What does this MR do?
Bug visible by creating a pipeline for the python-pip test project, and where DS_PIP_VERSION
is set. See https://gitlab.com/gitlab-org/security-products/tests/python-pip/-/jobs/1765259085 for instance; it does not install the requested version of pip.
Link to create such pipelines: https://gitlab.com/gitlab-org/security-products/tests/python-pip/-/pipelines/new?var[DS_PIP_VERSION]=20.0.1&var[SECURE_LOG_LEVEL]=debug
As a comparison, here's corresponding job when running the Docker image built in this MR: https://gitlab.com/gitlab-org/security-products/tests/python-pip/-/jobs/1765260797#L26. This job starts with the installation of the request version of pip:
[DEBU] [gemnasium-python] [2021-11-09T17:44:14Z] ▶ /usr/local/bin/python /get-pip.py --disable-pip-version-check --no-cache-dir pip==20.0.1
Collecting pip==20.0.1
Downloading https://files.pythonhosted.org/packages/57/36/67f809c135c17ec9b8276466cc57f35b98c240f55c780689ea29fa32f512/pip-20.0.1-py2.py3-none-any.whl (1.5MB)
This was surfaced when copying main.go to gemnasium-maven. See gemnasium-maven!132 (comment 728295344)
CI variables not processed by the pip
builder prior to that change:
DS_PIP_VERSION
DS_PIP_DEPENDENCY_PATH
-
PIP_CERT
(not documented but possibly used; see pip documentation) -
DS_GET_PIP_PATH
(not documented, implementation detail)
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated for GitLab EE, if necessary -
Documentation created/updated for this project, if necessary -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Job definition updated, if necessary -
Conforms to the code review guidelines -
Conforms to the Go guidelines -
Security reports checked/validated by reviewer