Skip to content

Fix configuration so that test dependencies are not skipped when skipTestsGroups is set to false

Nick Ilieskou requested to merge nilieskou/dont_skip_test_deps into master

What does this MR do

Fixes the skipTestsGroups configuration so that tests are not skipped when is set to false

Related issues

The gemnasium gradle plugin does not respect co... (gitlab-org/gitlab#443849 - closed)

Testing

Tested this MR using the manual-test/initscript/singleproject.

Applied the following change

test code
diff --git a/manual-test/initscript/gl-gemnasium-init.gradle b/manual-test/initscript/gl-gemnasium-init.gradle
index 94a7098..9c1d48a 100644
--- a/manual-test/initscript/gl-gemnasium-init.gradle
+++ b/manual-test/initscript/gl-gemnasium-init.gradle
@@ -11,11 +11,11 @@ initscript {
 
 allprojects {
   apply plugin: com.gemnasium.GemnasiumGradlePlugin
-  
+
   gemnasiumGradlePlugin {
     //outputDir = file('.')
     //outputFileName = "gradle-dependencies.json"
-    //skipTestGroups = false
+    skipTestGroups = false
     //skipConfigurations = ['compile']
     //scanConfigurations = ['compileClasspath']
   }
diff --git a/manual-test/initscript/singleproject/build.gradle b/manual-test/initscript/singleproject/build.gradle
index 1c79ffe..9c75dbf 100644
--- a/manual-test/initscript/singleproject/build.gradle
+++ b/manual-test/initscript/singleproject/build.gradle
@@ -15,7 +15,7 @@ repositories {
 }
 
 dependencies {
-  compile group: 'org.aeonbits.owner', name: 'owner', version:'1.0.10'
+  // compile group: 'org.aeonbits.owner', name: 'owner', version:'1.0.10'
   compile group: 'io.grpc', name: 'grpc-core', version:'1.19.0'
   compile group: 'com.google.code.gson', name: 'gson', version:'2.7'
   compile group: 'org.apache.hadoop', name: 'hadoop-common', version:'3.2.0'
@@ -29,4 +29,6 @@ dependencies {
   compile group: 'org.apache.kafka', name: 'kafka_2.11', version:'0.9.0.1'
   compile group: 'net.bull.javamelody', name: 'javamelody-core', version:'1.59.0'
   compile group: 'com.orientechnologies', name: 'orientdb-server', version:'2.1.9'
+  // testImplementation 'org.springframework.boot:spring-boot-starter-test:2.3.4.RELEASE'
+  testImplementation group: 'org.aeonbits.owner', name: 'owner', version:'1.0.10'
 }

and observed that org.aeonbits.owner shows up in the report when skipTestGroups is set to false.

Edited by Nick Ilieskou

Merge request reports