Skip to content

Use testify in tests

Adam Cohen requested to merge add-testify into master

What does this MR do?

This MR changes all comparison logic in tests to use testify

  1. Change error checking:

    Instead of:

    if err != nil {
  t.Fatal(err)
}

    Use:

    require.NoError(t, err)

  2. Change equality checks:

    Instead of:

    if !reflect.DeepEqual(got, tc.want) {
  t.Errorf("Wrong result. Expected %#v but got %#v", tc.want, got)
}

    Use:

    require.Equal(t, tc.want, got)

Why use require instead of assert?

By using require, the tests will fail immediately, whereas using assert will allow subsequent statements to be executed, which is confusing

What are the relevant issue numbers?

gitlab-org/gitlab#230600 (closed)

Does this MR meet the acceptance criteria?

Edited by Adam Cohen

Merge request reports