Skip to content

OpenShift support

Fabien Catteau requested to merge openshift-support into master

What does this MR do?

Give write access to group id 0 to enable OpenShift support. When running on OpenShift, user id is random and group id is 0. When running on .com, the default user remains root, to ensure backward compatibility. See gitlab-org/gitlab#290240 (comment 509916812)

Also, add test jobs for offline-FREEZE branch of one of the Secure test project to make sure that it's still possible to have a before_script with instructions executed as root. See gitlab-org/gitlab#290240 (comment 509928251)

How is it tested?

Tested using !67 (closed)

See successful scanning job where the generated report is checked after the scan:

Failing job when setting ADDITIONAL_CA_CERT_BUNDLE to a fake certificate, but this proves that the analyzer can update /etc/gitconfig, because if it couldn't, the error would explain that the file could not be written, but instead we're seeing an SSL error, which is fine:

Value of ADDITIONAL_CA_CERT_BUNDLE was:

-----BEGIN CERTIFICATE-----
certificate-contents-go-here
-----END CERTIFICATE-----

What are the relevant issue numbers?

gitlab-org/gitlab#290240 (closed)

Does this MR meet the acceptance criteria?

Edited by Adam Cohen

Merge request reports