Skip to content

Set DEFAULT_ISSUE_SEARCH_IGNORED_LABELS to empty array

Shao Ming Tan requested to merge fix-resolve-and-close into master

What does this MR do?

The resolve and close command is resolving vulnerabilities but not closing the related issues as reported in this slack thread by @gonzoyumo:

image

This is caused by the ignored? check in the issue.close! method.

The ignored labels are: FedRAMP DR Status::Open, CVSS Source::NVD, CVSS Source::Vendor

The check for ignored labels is performed in the following cases:

  1. When closing issues.

    This check is probably not needed, as discussed here, however, we're keeping this behaviour for the time being.

  2. When updating issues.

    The code for updating issues was a one off task that should probably be removed now that it's no longer needed, however, we've decided to remove this in a follow-up MR. See this thread for details.

This MR sets the DEFAULT_ISSUE_SEARCH_IGNORED_LABELS to an empty array, so that the ignored? checks will pass in the default case, however, it can be overridden by setting the --ignored-labels flag, if desired.

Edited by Adam Cohen

Merge request reports