Skip to content

Adds outcomes and discussion sizes

James Johnson requested to merge 11-add_outcomes into master

Adds outcomes to discoto and discussion size indicators.

High-level points:

  1. Can now declare outcome: AABBCC in addition to point: AABBCC
    • If an outcome is declared, all points and sub-topics are collapsed underneath the outcome
  2. Nothing is collapsed at the top level until outcomes are added
    • The gif shows a top-level outcome with collapsed points/sub-topics
    • The screenshot does not have a top-level outcome, which means nothing is collapsed
  3. Adds relative discussion-size indicators with braille
    • More dots == relatively larger discussion
    • Max number of braille dots == 24, if discussion sizes are larger, one dot will map to multiple discussion units
    • discussion_size == points.size + sub_topics.size + sub_topics.map(&:discussion_size).sum / 2.0
      • Discussion units within sub-topics count at half the rate as discussion units at higher levels

Fixes #11

Screenshots

The gif below shows nested outcomes, with everything being collapsed under the top-level outcome. See this issue for the source of the gif.

discoto_outcomes_and_discussion_size

The screenshot below is a good example of the relative discussion size indicators (the braille dots). More dots == more discussions have occurred, including in sub topics. See this issue for the source of the screenshot

image

Checklist

  • Manually verified passing unit tests for this branch locally by running bin/run_docker_tests.sh
    • Yes, this is a pain, but GitLab doesn't run reasonably within a docker container in a normal CI pipeline
    • See bin/run_docker_tests.sh --help for faster/iterative testing options
  • Paste local test output

Local Test Output

/bin/run_docker_tests.sh output
OUTPUT HERE

Closes #11

Edited by James Johnson

Merge request reports