Skip to content

Fix MrMetricMan key checked for halted migrations

Terri Chu requested to merge tchu-fix-mr-metric-man-halted-check into master

Fix MrMetricMan which is currently reporting halted migrations as pending.

Issue was not checking the correct key in the source

Example failed migration json:

{"completed"=>false,
 "name"=>"DeleteWikisFromOriginalIndex",
 "started_at"=>"2023-07-24T10:25:07.449Z",
 "state"=>
  {"task_id"=>nil,
   "documents_remaining"=>181340,
   "previous_attempts"=>29,
   "halted"=>true,
   "halted_indexing_unpaused"=>false,
   "message"=>"MigrationWorker: migration has failed with RuntimeError:Failed to delete wikis, no retries left",
   "failed"=>true}}

Before

...

- :mag_right: pending migrations
    - <https://gprd-indexing-20220523.es.us-central1.gcp.cloud.es.io:9243/gitlab-production-migrations/_doc/20230720010000|DeleteWikisFromOriginalIndex> (in progress) started at: `2023-07-24T10:25:07.449Z`
    - <https://gprd-indexing-20220523.es.us-central1.gcp.cloud.es.io:9243/gitlab-production-migrations/_doc/20230719094700|RemoveProjectsFromMainIndex> (in progress) started at: `2023-07-26T08:22:16.361Z`
    - <https://gprd-indexing-20220523.es.us-central1.gcp.cloud.es.io:9243/gitlab-production-migrations/_doc/20230724151612|BackfillArchivedFieldInCommits> (in progress) started at: `2023-08-01T22:00:24.168Z`

After

....

- :mag_right: pending migrations
    - <https://gprd-indexing-20220523.es.us-central1.gcp.cloud.es.io:9243/gitlab-production-migrations/_doc/20230720010000|DeleteWikisFromOriginalIndex> (halted) started at: `2023-07-24T10:25:07.449Z`
    - <https://gprd-indexing-20220523.es.us-central1.gcp.cloud.es.io:9243/gitlab-production-migrations/_doc/20230719094700|RemoveProjectsFromMainIndex> (halted) started at: `2023-07-26T08:22:16.361Z`
    - <https://gprd-indexing-20220523.es.us-central1.gcp.cloud.es.io:9243/gitlab-production-migrations/_doc/20230724151612|BackfillArchivedFieldInCommits> (in progress) started at: `2023-08-01T22:00:24.168Z`

Merge request reports