CI: Ensure that GITLAB_API_TOKEN is correct
Fail update-changelog
if the provided GITLAB_API_TOKEN is invalid
(e.g. missing or protected). Closes #29 (closed)
Also, improve release documentation to highlight that CHANGELOG.md
should be updated by project bot
Testing
In order to perform these tests GITLAB_API_TOKEN
is no longer a protected
CI/CD variable:
With this, update-changelog
is run and fails if the API token does not have sufficient permissions.
![]() |
![]() |
---|---|
https://gitlab.com/gitlab-org/ruby/gems/tanuki_emoji/-/jobs/5012800713 | https://gitlab.com/gitlab-org/ruby/gems/tanuki_emoji/-/jobs/5012827332 |
See also !57 (d0009eb3) to see CHANGELOG.md
in this very MR
Merge request reports
Activity
assigned to @splattael
1 Warning Please add a merge request type to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer No reviewer available Tetiana Chupryna (
@brytannia
) (UTC+2, same timezone as@splattael
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@splattael - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added 2 commits
mentioned in issue #29 (closed)
added 1 commit
- f7bbf016 - CI: Ensure that GITLAB_API_TOKEN is defined and correct
added 2 commits
added Engineering Productivity maintenancepipelines typemaintenance labels
- Resolved by Kerri Miller
- Resolved by Kerri Miller
- Resolved by Kerri Miller
requested review from @nmilojevic1
mentioned in merge request !56 (merged)
requested review from @kerrizor
mentioned in commit 422d1d2a