Skip to content

Fix parsing of underscores in Maven versions

Fabien Catteau requested to merge fix-maven-incomplete-scan-error into master

What does this MR do?

Fix parsing errors of underscores in Maven versions.

This allows to parse the following versions:

4.1.109.Final-linux-x86_64
2.7.7_5
4.1.110.Final-linux-x86_64
0.0.62.Final-linux-x86_64
hadoop3-2.0.0
2.11.3-spark_3.3
3.4.0_1.4.2

Output of reference implementation:

1. 1_1 -> 1-_-1; tokens: [1, [_, [1]]]
   1_1 < 1_a
2. 1_a -> 1-_a; tokens: [1, [_a]]
   1_a > 1_
3. 1_ -> 1-_; tokens: [1, [_]]
   1_ < 1__
4. 1__ -> 1-__; tokens: [1, [__]]
   1__ > 1_-
5. 1_- -> 1-_; tokens: [1, [_]]

What are the relevant issue numbers?

Maven versions containing an underscore are inc... (gitlab-org/gitlab#466074 - closed)

Does this MR meet the acceptance criteria?

Edited by Fabien Catteau

Merge request reports