Skip to content
Snippets Groups Projects
Vitaly Slobodin's avatar
commented on task #43 "Upgrade `gitlab-dangerfiles` to v4" at GitLab.org / ruby / gems / labkit-ruby

Completed via !133 (merged)

Vitaly Slobodin's avatar
closed task #43 "Upgrade `gitlab-dangerfiles` to v4" at GitLab.org / ruby / gems / labkit-ruby
Bob Van Landuyt's avatar
deleted branch vs/update-gitlab-styles-gem at GitLab.org / ruby / gems / labkit-ruby
Bob Van Landuyt's avatar
Bob Van Landuyt's avatar
accepted merge request !133 "Update `gitlab-styles` to v13 to get new Rubocop version" at GitLab.org / ruby / gems / labkit-ruby
Bob Van Landuyt's avatar
approved merge request !133 "Update `gitlab-styles` to v13 to get new Rubocop version" at GitLab.org / ruby / gems / labkit-ruby
Matthias Käppler's avatar
commented on merge request !133 "Update `gitlab-styles` to v13 to get new Rubocop version" at GitLab.org / ruby / gems / labkit-ruby

@reprazent Passing to you for maintainer review.

Matthias Käppler's avatar
approved merge request !133 "Update `gitlab-styles` to v13 to get new Rubocop version" at GitLab.org / ruby / gems / labkit-ruby
Matthias Käppler's avatar
commented on merge request !133 "Update `gitlab-styles` to v13 to get new Rubocop version" at GitLab.org / ruby / gems / labkit-ruby

LGTM, thanks!...

Matthias Käppler's avatar
commented on merge request !133 "Update `gitlab-styles` to v13 to get new Rubocop version" at GitLab.org / ruby / gems / labkit-ruby

Yes, good point!

Matthias Käppler's avatar
commented on merge request !133 "Update `gitlab-styles` to v13 to get new Rubocop version" at GitLab.org / ruby / gems / labkit-ruby

Thanks @vitallium ! I don't think I'll get to this MR today and I'm out tomorrow. If urgent, consider reassigning. Otherwise happy to take a look o...

Vitaly Slobodin's avatar
closed issue #40 "Upgrade Ruby to 3.2 and drop support for older Rubies (< 3.2)" at GitLab.org / ruby / gems / labkit-ruby
Vitaly Slobodin's avatar
commented on merge request !133 "Update `gitlab-styles` to v13 to get new Rubocop version" at GitLab.org / ruby / gems / labkit-ruby

@mkaeppler can you please review this small MR? Thanks!

DANGER_GITLAB_API_TOKEN's avatar
commented on merge request !133 "Update `gitlab-styles` to v13 to get new Rubocop version" at GitLab.org / ruby / gems / labkit-ruby
...
Vitaly Slobodin's avatar
commented on merge request !133 "Update `gitlab-styles` to v13 to get new Rubocop version" at GitLab.org / ruby / gems / labkit-ruby

I think the intention here is to use rubocop rather than running tests.

Vitaly Slobodin's avatar
opened merge request !133 "Update `gitlab-styles` to v13 to get new Rubocop version" at GitLab.org / ruby / gems / labkit-ruby
Vitaly Slobodin's avatar
pushed new branch vs/update-gitlab-styles-gem at GitLab.org / ruby / gems / labkit-ruby
Matthias Käppler's avatar
deleted branch vs/bump-ruby-to-3-2 at GitLab.org / ruby / gems / labkit-ruby
Matthias Käppler's avatar
Matthias Käppler's avatar
accepted merge request !129 "Bump the minimum required Ruby version to 3.2" at GitLab.org / ruby / gems / labkit-ruby