Abdul Wadood authored Oct 14, 2024 and Peter Leitzen committed Oct 14, 2024

>>>
For empty test description blocks, use `specify` rather than `it do` if the
test is self-explanatory.
>>>

The [RSpec/ExampleWithoutDescription cop](https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecexamplewithoutdescription)
is enabled by default. Here we are changing the EnforcedStyle of the cop to
[single_line_only](https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#enforcedstyle-single_line_only)
to match the above quoted [testing guidelines](https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#general-guidelines).

## Examples

```ruby
# bad
it do

# good
specify do
```

## Impact on gitlab-org/gitlab

```
bundle exec rubocop $f --only RSpec/ExampleWithoutDescription
39218 files inspected, 1181 offenses detected
```

Changelog: added

Change RSpec/ExampleWithoutDescription style to single_line_only

See merge request !241



Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Thong Kuah <tkuah@gitlab.com>
Approved-by: drew stachon <730684-drew@users.noreply.gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: Abdul Wadood <awadood@gitlab.com>

With that we can also remove the monkey patch for
`InternalAffairs/CopDescriptionWithExample` as it's no longer needed and
fails now.

Changelog: other

lib/rubocop/cop/gitlab_security/json_serialization.rb:33: warning:
Inheriting from `RuboCop::Cop::Cop` is deprecated. Use
`RuboCop::Cop::Base` instead.  For more information, see
https://docs.rubocop.org/rubocop/v1_upgrade_notes.html.

Upgrade RuboCop to 1.67.0

See merge request !242



Merged-by: Rémy Coutable <remy@rymai.me>
Approved-by: Rémy Coutable <remy@rymai.me>
Reviewed-by: Rémy Coutable <remy@rymai.me>
Reviewed-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: Peter Leitzen <pleitzen@gitlab.com>

Release version 13.0.1

See merge request !243



Merged-by: Rémy Coutable <remy@rymai.me>
Approved-by: Rémy Coutable <remy@rymai.me>
Reviewed-by: Rémy Coutable <remy@rymai.me>
Co-authored-by: Peter Leitzen <pleitzen@gitlab.com>