Enable Naming/InclusiveLanguage cop rule (!159) · Merge requests · GitLab.org / ruby / gems / gitlab-styles

Peter Leitzen requested to merge pl-naming-inclusive-language into master Jan 15, 2023

What does this MR do and why?

Enable 👮 rule Naming/InclusiveLanguage which contributes to https://about.gitlab.com/handbook/communication/top-misused-terms/.

Additionally to identifiers etc. this cop also checks strings for misused terms.

It also fixes remaining offenses for Naming/InclusiveLanguage in this repository.

Impact on `gitlab-org/gitlab`

Click to expand

== app/controllers/admin/application_settings/appearances_controller.rb ==
C: 63: 37: Naming/InclusiveLanguage: Consider replacing 'white list' with 'allowlist' or 'permit'.
== app/controllers/application_controller.rb ==
C: 93: 31: Naming/InclusiveLanguage: Consider replacing 'Blacklist' with 'denylist' or 'block'.
== app/controllers/concerns/requires_whitelisted_monitoring_client.rb ==
C:  1:  1: Naming/InclusiveLanguage: Consider replacing 'whitelist' in file path with 'allowlist' or 'permit'.
C:  3: 16: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
C:  7: 32: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 12: 19: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 16: 17: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 21:  8: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 24: 10: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 25:  9: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 25: 46: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== app/controllers/health_check_controller.rb ==
C:  4: 19: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
== app/controllers/health_controller.rb ==
C:  6: 19: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
== app/controllers/metrics_controller.rb ==
C:  5: 19: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
== app/helpers/application_settings_helper.rb ==
C:486: 20: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== app/helpers/blob_helper.rb ==
C:119: 57: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:120: 45: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== app/helpers/markup_helper.rb ==
C: 75: 32: Naming/InclusiveLanguage: Consider replacing 'WhiteList' with 'allowlist' or 'permit'.
== app/models/application_setting.rb ==
C: 73: 26: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:100: 38: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== app/models/application_setting_implementation.rb ==
C:319: 50: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:325: 34: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:328: 38: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:331: 34: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:332: 34: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:334: 34: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:338: 49: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:343: 57: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:345: 89: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:375: 19: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:381: 23: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:383: 54: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:386: 33: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== app/models/clusters/applications/jupyter.rb ==
C: 90: 31: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
C: 91: 27: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
== app/models/concerns/cache_markdown_field.rb ==
C: 10: 34: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== app/services/application_settings/update_service.rb ==
C:  9:116: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 30: 38: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 30: 95: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 57: 40: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 61: 59: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== app/services/projects/download_service.rb ==
C:  5:  5: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
C: 36:  7: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
== app/uploaders/avatar_uploader.rb ==
C: 31: 20: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== app/uploaders/content_type_whitelist.rb ==
C:  1:  1: Naming/InclusiveLanguage: Consider replacing 'whitelist' in file path with 'allowlist' or 'permit'.
C:  3: 61: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:  7: 55: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 10: 47: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 15: 13: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 19: 19: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
C: 28: 28: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 29: 23: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 33: 59: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 33:111: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 39:  9: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 40: 26: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== app/uploaders/design_management/design_v432x230_uploader.rb ==
C: 28: 22: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== app/uploaders/favicon_uploader.rb ==
C:  7: 17: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 11: 20: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== app/uploaders/gitlab_uploader.rb ==
C:  4: 22: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
== app/uploaders/import_export_uploader.rb ==
C: 10: 17: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== app/validators/cron_validator.rb ==
C:  4: 13: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
C:  6:  6: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
C:  9: 18: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
C: 13: 16: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
C: 13: 48: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== app/validators/qualified_domain_array_validator.rb ==
C: 12: 42: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== config/initializers/1_settings.rb ==
C:1005: 41: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:1033: 25: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== config/initializers/doorkeeper.rb ==
C: 63: 25: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== config/initializers/workhorse_multipart.rb ==
C: 11: 21: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== ee/app/controllers/projects/push_rules_controller.rb ==
C: 34: 37: Naming/InclusiveLanguage: Consider replacing 'white list' with 'allowlist' or 'permit'.
== ee/lib/arkose/verify_response.rb ==
C:  9: 35: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== ee/lib/system_check/geo/http_connection_check.rb ==
C: 65: 68: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== ee/spec/lib/gitlab/checks/diff_check_spec.rb ==
C:193: 16: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
C:198: 41: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
C:201: 11: Naming/InclusiveLanguage: Consider replacing 'white_list' with 'allowlist' or 'permit'.
C:207: 11: Naming/InclusiveLanguage: Consider replacing 'white_list' with 'allowlist' or 'permit'.
C:223: 11: Naming/InclusiveLanguage: Consider replacing 'black_list' with 'denylist' or 'block'.
C:230: 11: Naming/InclusiveLanguage: Consider replacing 'black_list' with 'denylist' or 'block'.
== ee/spec/models/dora/lead_time_for_changes_metric_spec.rb ==
C: 64:111: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== lib/api/entities/application_setting.rb ==
C: 42: 55: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== lib/api/settings.rb ==
C: 45: 29: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 45:299: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:243: 38: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:244: 67: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== lib/banzai/filter/asset_proxy_filter.rb ==
C: 63: 49: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== lib/gitlab/asset_proxy.rb ==
C: 20: 22: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== lib/gitlab/auth.rb ==
C:  6:  7: Naming/InclusiveLanguage: Consider replacing 'Blacklist' with 'denylist' or 'block'.
C: 54: 17: Naming/InclusiveLanguage: Consider replacing 'Blacklist' with 'denylist' or 'block'.
== lib/gitlab/auth/ip_rate_limiter.rb ==
C: 56: 21: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== lib/gitlab/ci/config/external/file/base.rb ==
C: 13: 18: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
C: 30: 71: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
== lib/gitlab/git/hook_env.rb ==
C: 17:  7: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
C: 28: 68: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 49: 16: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 50: 31: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
== lib/gitlab/github_import/markdown/attachment.rb ==
C: 66: 15: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== lib/gitlab/markdown_cache/active_record/extension.rb ==
C: 23: 11: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 23: 60: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 24: 42: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 27: 54: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== lib/gitlab/markdown_cache/field_data.rb ==
C: 26: 23: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 28: 34: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== lib/gitlab/middleware/basic_health_check.rb ==
C: 40: 21: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 41: 12: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 44: 14: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 45: 13: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 45: 50: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== lib/gitlab/middleware/go.rb ==
C: 21: 30: Naming/InclusiveLanguage: Consider replacing 'Blacklist' with 'denylist' or 'block'.
== lib/gitlab/sanitizers/exif.rb ==
C:  7:  7: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
C: 46: 22: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
C: 47: 24: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
C: 88: 63: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:112: 42: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== lib/gitlab/sanitizers/svg.rb ==
C: 15: 18: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
C: 20: 30: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
C: 46: 11: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
== lib/gitlab/sanitizers/svg/whitelist.rb ==
C:  1:  1: Naming/InclusiveLanguage: Consider replacing 'whitelist' in file path with 'allowlist' or 'permit'.
C:  9: 13: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
== lib/system_check/app/git_user_default_ssh_config_check.rb ==
C:  7:  9: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:  8:  7: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
C: 65: 13: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 65: 27: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
C: 67: 23: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== rubocop/cop/active_record_association_reload.rb ==
C:  5: 16: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
== rubocop/cop/avoid_becomes.rb ==
C:  5: 16: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
== rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb ==
C:  5: 16: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
== rubocop/cop/avoid_return_from_blocks.rb ==
C: 26:  7: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
C: 35: 66: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 72: 11: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 73:  9: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
== rubocop/cop/default_scope.rb ==
C:  5: 16: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
== rubocop/cop/destroy_all.rb ==
C:  5: 16: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
== rubocop/cop/graphql/id_type.rb ==
C:  9:  9: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
C: 24: 12: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
== rubocop/cop/group_public_or_visible_to_user.rb ==
C:  5: 16: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
== rubocop/cop/ignored_columns.rb ==
C:  5: 16: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
== rubocop/cop/inject_enterprise_edition_module.rb ==
C:  5: 16: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
C: 83: 41: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
== rubocop/cop/migration/add_columns_to_wide_tables.rb ==
C: 15:  9: Naming/InclusiveLanguage: Consider replacing 'BLACKLIST' with 'denylist' or 'block'.
C: 36: 13: Naming/InclusiveLanguage: Consider replacing 'BLACKLIST' with 'denylist' or 'block'.
== spec/controllers/application_controller_spec.rb ==
C:908: 41: Naming/InclusiveLanguage: Consider replacing 'Blacklist' with 'denylist' or 'block'.
C:913: 31: Naming/InclusiveLanguage: Consider replacing 'Blacklist' with 'denylist' or 'block'.
== spec/controllers/concerns/issuable_collections_spec.rb ==
C: 95: 23: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:126: 23: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/controllers/health_check_controller_spec.rb ==
C: 10:  8: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 11: 12: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 14: 47: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 14: 70: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 19: 61: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 21: 86: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 49: 53: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 51: 82: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 94: 70: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 97: 82: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/controllers/metrics_controller_spec.rb ==
C:  9:  8: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 10:  8: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 11: 14: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 12: 12: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 25: 47: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 25: 70: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 25: 86: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 32: 28: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 34: 82: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 40: 34: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 42: 88: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 48: 32: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 50: 86: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/features/projects/import_export/export_file_spec.rb ==
C:  8: 33: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
== spec/helpers/markup_helper_spec.rb ==
C:521: 17: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/lib/banzai/filter/asset_proxy_filter_spec.rb ==
C: 53: 29: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/lib/gitlab/asset_proxy_spec.rb ==
C: 42: 14: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 43: 50: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 49: 55: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/lib/gitlab/auth/ip_rate_limiter_spec.rb ==
C:  7:  8: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 11: 21: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 40: 22: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 50: 21: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 52: 21: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 56: 24: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 59: 21: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 61: 21: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 65: 24: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/lib/gitlab/auth_spec.rb ==
C: 98: 25: Naming/InclusiveLanguage: Consider replacing 'Blacklist' with 'denylist' or 'block'.
C: 99: 61: Naming/InclusiveLanguage: Consider replacing 'Blacklist' with 'denylist' or 'block'.
== spec/lib/gitlab/git/hook_env_spec.rb ==
C: 18: 11: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/lib/gitlab/github_import/markdown/attachment_spec.rb ==
C: 25: 36: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 61: 36: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/lib/gitlab/import_export/attribute_configuration_spec.rb ==
C:  9: 44: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
== spec/lib/gitlab/import_export/references_configuration_spec.rb ==
C:  9: 12: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
== spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb ==
C:146: 43: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
== spec/lib/gitlab/middleware/basic_health_check_spec.rb ==
C: 43: 51: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 53: 28: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 54: 51: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 62: 14: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/lib/gitlab/middleware/go_spec.rb ==
C:139: 37: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
C:141:105: Naming/InclusiveLanguage: Consider replacing 'Blacklist' with 'denylist' or 'block'.
== spec/lib/gitlab/sanitizers/exif_spec.rb ==
C:264: 50: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/lib/system_check/app/git_user_default_ssh_config_check_spec.rb ==
C: 20: 12: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 21: 29: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
C: 65: 29: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 66: 24: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
== spec/models/application_setting_spec.rb ==
C: 57: 91: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 58: 95: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 59: 79: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 60: 83: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 61: 86: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 62: 89: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 63: 85: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 64: 82: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 65: 75: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 66: 70: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:900: 30: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:903: 33: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:904: 40: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:910: 33: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:911: 40: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:915: 33: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:916: 40: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:920: 33: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:921: 40: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/models/clusters/applications/jupyter_spec.rb ==
C:104: 51: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
C:123: 47: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
== spec/requests/api/settings_spec.rb ==
C:270: 37: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/requests/health_controller_spec.rb ==
C:  9:  8: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 10: 12: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 15: 47: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 15: 70: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 56: 28: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 58: 26: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 65: 32: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 67: 30: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:221: 28: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:223: 26: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:238: 32: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:240: 30: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:275: 28: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:277: 26: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:284: 32: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:286: 30: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/rubocop/cop/avoid_return_from_blocks_spec.rb ==
C: 44: 34: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 44: 58: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 45: 52: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 47: 17: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 55: 46: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 56: 36: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 56: 57: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/rubocop/cop/graphql/id_type_spec.rb ==
C: 15: 12: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 16: 36: Naming/InclusiveLanguage: Consider replacing 'WHITELIST' with 'allowlist' or 'permit'.
== spec/services/application_settings/update_service_spec.rb ==
C: 65: 46: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 71: 56: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 76: 56: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 78: 54: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 85: 56: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 88: 61: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 96: 54: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:103: 56: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:106: 61: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/services/design_management/generate_image_versions_service_spec.rb ==
C: 18: 65: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/services/error_tracking/list_issues_service_spec.rb ==
C: 45: 64: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/services/projects/download_service_spec.rb ==
C: 12: 39: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 21: 39: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/support/import_export/export_file_helper.rb ==
C: 91: 19: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/support/shared_contexts/upload_type_check_shared_context.rb ==
C:  5: 73: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:  8: 43: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 12: 34: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 12: 61: Naming/InclusiveLanguage: Consider replacing 'blacklist' with 'denylist' or 'block'.
== spec/support/shared_examples/lib/banzai/filters/sanitization_filter_shared_examples.rb ==
C: 28: 14: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/support/shared_examples/models/application_setting_shared_examples.rb ==
C: 64: 36: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 65:103: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 83: 39: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:101: 10: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:113: 14: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:122: 12: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:122: 30: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:127: 43: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:128: 47: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:129: 39: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:131: 46: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:135: 46: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:143: 39: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:150: 46: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:161: 39: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:163: 46: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:165: 46: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C:172: 39: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/uploaders/avatar_uploader_spec.rb ==
C: 50: 19: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 64: 23: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 70: 32: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/uploaders/content_type_whitelist_spec.rb ==
C:  1:  1: Naming/InclusiveLanguage: Consider replacing 'whitelist' in file path with 'allowlist' or 'permit'.
C:  5: 27: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
C: 12: 26: Naming/InclusiveLanguage: Consider replacing 'Whitelist' with 'allowlist' or 'permit'.
C: 14: 24: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 22: 19: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 29: 23: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 35: 32: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/uploaders/design_management/design_v432x230_uploader_spec.rb ==
C: 61: 19: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 75: 23: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 81: 32: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/uploaders/favicon_uploader_spec.rb ==
C:  9: 19: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 25: 23: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 33: 32: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
== spec/validators/cron_validator_spec.rb ==
C: 32: 30: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.
C: 46: 68: Naming/InclusiveLanguage: Consider replacing 'whitelist' with 'allowlist' or 'permit'.

29509 files inspected, 305 offenses detected

29509 files inspected, 305 offenses detected.

Mostly related to the use of whilelist and blacklist. See https://about.gitlab.com/handbook/communication/top-misused-terms/#whitelist.

Cop config

Via rubocop --show-cops Naming/InclusiveLanguage:

Naming/InclusiveLanguage:
  Description: Recommend the use of inclusive language instead of problematic terms.
  Enabled: true
  VersionAdded: '1.18'
  VersionChanged: '1.21'
  CheckIdentifiers: true
  CheckConstants: true
  CheckVariables: true
  CheckStrings: true
  CheckSymbols: true
  CheckComments: true
  CheckFilepaths: true
  FlaggedTerms:
    whitelist:
      Regex: !ruby/regexp /white[-_\s]?list/
      Suggestions:
      - allowlist
      - permit
    blacklist:
      Regex: !ruby/regexp /black[-_\s]?list/
      Suggestions:
      - denylist
      - block
    slave:
      WholeWord: true
      Suggestions:
      - replica
      - secondary
      - follower

Edited Jan 15, 2023 by Peter Leitzen

Enable Naming/InclusiveLanguage cop rule

What does this MR do and why?

Impact on gitlab-org/gitlab

Cop config

Merge request reports

Impact on `gitlab-org/gitlab`