Skip to content

Disable RSpec cops that enforces one style of writing specs

Albert requested to merge alberts-gitlab-master-patch-57008 into master

What does this MR do and why?

When writing spec, we should leave it to the author to choose the preferred style of writing it.

Having the cops enabled forces one style . However, there may be situations where one style is more appropriate than the other.

# RSpec/ExpectChange
expect { service.execute }.not_to change { build.has_trace? }.from(true)
expect { service.execute }.not_to change(build, :has_trace?).from(true)

# RSpec/PredicateMatcher
expect(build.trace?).to be_falsey
expect(build).to be_trace
Edited by Albert

Merge request reports