Enable new cops by default

In !119 (merged), I set NewCops: disable to avoid making the upgrade MR too big. However, we should probably take new cops by default?

List

Updating the list

Copy this 👇 script and save as merge.rb

# frozen_string_literal: true

require "active_support/all"

BULLET_REGEXP = %r{^- \[.\] `(\S+)` (?:-|#)}
WARNINGS_REGEXP = %r{^(\S+): (# new.*)}

# Copy existing bullet point list (markdown) from
# https://gitlab.com/gitlab-org/ruby/gems/gitlab-styles/-/issues/40 as `bullets`.
bullets = File
  .readlines("bullets")
  .index_by { BULLET_REGEXP.match(_1)&.captures&.first }
  .compact

# Run `bundle exec rubocop --show-cops 2>warnings`.
File
  .readlines("warnings")
  .to_h { WARNINGS_REGEXP.match(_1)&.captures || [nil, nil] }
  .compact
  .each do |cop_name, comment|
    bullets[cop_name] ||= "- [ ] `#{cop_name}` #{comment}"
  end

content = bullets.sort_by { |(k, _)| k || "?" }.map { _2.chomp }.join("\n")

File.write("bullets.new", content)
puts "Written bullets.new"

Copy existing bullet points as markdown into bullets file
Comment NewCops: disable in .rubocop.yml and run bundle exec rubocop --show-cops 2> warnings
Run bundle exec ruby merge.rb
Paste bullets.new into this issue description

Edited Oct 17, 2023 by Peter Leitzen