Skip to content

Fix health check documentation

Stan Hu requested to merge sh-fix-health-check-docs into master

The documentation originally showed the health check took in an array.

  1. The configuration gets passed directly here via config[:health_check]: https://gitlab.com/gitlab-org/gitlab-mail_room/-/blob/a4489b51b375aa20a7866cf748695a399402dc70/lib/mail_room/configuration.rb#L21
  2. Here we access the address and port fields directly: https://gitlab.com/gitlab-org/gitlab-mail_room/-/blob/a4489b51b375aa20a7866cf748695a399402dc70/lib/mail_room/health_check.rb#L8-9

Discovered while working on gitlab-org/charts/gitlab!1891 (merged).

Edited by Stan Hu

Merge request reports