Skip to content

Remove Sidekiq `probe_jobs` probe

Sean McGivern requested to merge remove-probe-jobs into master

This was generally fast but had two unfortunate effects that made it impractical in production:

  1. The script got slower the larger the queue, as it scanned all jobs in queue.
  2. Because it was a Lua script, it blocked Redis execution entirely while running.

The combination of these two can lead to a catastrophic case. When a queue is very long, that's precisely the time when we want jobs to be processed quickly. But we'd see that jobs were blocked by the metrics script, which is the opposite of what we need at that time.

See https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/13776#note_624859081.

Merge request reports