Skip to content

Import Danger::Helper as internal plugin

Matthias Käppler requested to merge mk-add-missing-import into master

What does this MR do and why?

Add missing Danger::Helper import

Since we are now accessing Config in the Engine initializer, we are accessing Danger::Helper before we import all plugins, so we need to require it.

To that end, we now split internal from ordinary plugins and require internal plugins in the Engine initializer.

Fixes https://gitlab.com/gitlab-org/labkit-ruby/-/jobs/1837131511

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Matthias Käppler

Merge request reports