Group required_approvals by code owners
What does this MR do and why?
This MR removes duplicate required approvals using the rule's section (e.g. Backend
, Frontend
) and eligible_approvers as a filter. Closes https://gitlab.com/gitlab-org/gitlab-roulette/-/issues/41.
Testing
This change is tested in gitlab-org/gitlab!92580 (comment 1028191976).
gitlab-org/gitlab!85765 (comment 922034807)):
Before (![](/-/project/19861191/uploads/64cc5c5e66985f706ab75b75ebd35d80/gitlab-roulette_41-before.png)
gitlab-org/gitlab!92580 (comment 1028191976)):
After the fix (![](/-/project/19861191/uploads/a2afefe1ec222e640181a373719987e0/gitlab-roulette_41-after-fix.png)
![](/-/project/19861191/uploads/4d1b03ef737e492a6ce36ca3b3abbb8a/gitlab-roulette_41-code-owners.png)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Nao Hashizume