Skip to content

Add CI config for building and publishing

Matthias Käppler requested to merge mk-add-ci-config into master

The upstream project has been abandoned and did not have any maintained CI/CD setup.

In order to verify tests are passing in all current and future Rubies, this MR adds this setup.

Issues found:

  • 2 test failures in both Ruby 2.7 and 3.0 related to ActiveRecord
    • Decided to disable these tests since it does not look like we're affected by this. Instead of migrating the ActiveModel::Dirty integration logic to AR 6.1, we should probably just wait for the Rails 7 upgrade and drop this gem altogether.
  • Ruby 3 related call from attr_encrypted into ActiveModel::Dirt#attr_changed? required options splat
  • (Tests only) Ruby 3 related call from simplecov into json_pure initializer requires options splat
    • Disabled SimpleCov for now.

I also set up CI config for publishing this to rubygems.org. It is located here: https://rubygems.org/gems/gitlab-attr_encrypted

Refs gitlab-org/gitlab#372221 (closed)

Edited by Matthias Käppler

Merge request reports