2019-01-15: 11.7 exception request for gitlab-org/gitlab-ee!9163
Exception request
- Merge request to be considered for picking: gitlab-org/gitlab-ee!9163
Why it needs to be picked
Resolves Gitaly regression whereby unix domain socket communication doesn't work when http_proxy
environment variables are set. This has been reported by multiple users.
gitlab-org/gitaly#1447 (closed)
Potential negative impact of picking
- Unforeseen side effects
- Note that this change now includes integration tests for the package in question. These tests will help reduce risk around this change. Prior to this change, there were no tests to ensure that this functionality worked, now there are.
Release manager sign-off
(Assign this issue to RMs managing this release. See https://about.gitlab.com/release-managers/)
A release manager (not a trainee) needs to provide initial approval for this exception request.
-
Release manager @yorickpeterse or @rspeicher
Mention others as necessary during discussion.
Sign-off for RC (delete this section if patch release)
Upon initial approval, the release manager will then ping and assign the following roles:
-
Engineering Manager @glopezfernandez -
Engineering Manager, Quality @meks
If you are the last person to provide initial approval, assign this issue to the VPE for their approval:
-
VPE: @edjdev
After approval
Check that the following is accurate before closing this issue:
-
gitlab-org/gitlab-ee!9163 has the correct milestone and label set so that the release managers will pick it. -
gitlab-org/gitlab-ee!9163 has a comment with a link to this issue: - Exception approved in #640 (closed)
Edited by Yorick Peterse