2018-06-21: 11.0.2 exception request for https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6178
Exception request
- Merge request to be considered for picking: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6178
Why it needs to be picked
This is vital to close out a GCP Migration issue: gitlab-com/migration#577 (closed). The MR makes it possible for Geo nodes to work with the EE database load balancing code. Without it, we are running Geo without any load balancing.
The alternative is after the failover, we reconfigure the nodes to use it.
Potential negative impact of picking
This change affects only affects Geo secondaries. It's possible, although unlikely, that Geo secondaries won't be able to connect to the tracking DB when this change goes in. That should have been caught by our unit and integration tests, as well as manual testing on an Omnibus instance.
Release manager sign-off
The release manager needs to provide initial approval for this exception request.
-
Release manager (@mayra-cabrera)
Mention others as necessary during discussion.
If you are the last person to provide initial approval, assign this issue to the VPE for his approval:
-
VPE (@edjdev)
Sign-off for patch release (delete this section if RC)
Upon initial approval, the release manager will then ping and assign one more role for final approval:
-
Engineering team leader/Engineering department leader/Quality leader/VPE
After approval
Check that the following is accurate before closing this issue:
-
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6178 has the correct milestone and label set so that the release managers will pick it. -
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6178 has a comment with a link to this issue: - Exception approved in #288 (closed)