2019-06-21: 12.0.1 exception request for gitlab-org/gitlab-ee!14011
Exception request
- Merge request to be considered for picking: gitlab-org/gitlab-ee!14011
There is also a related CE MR gitlab-org/gitlab-ce!29296
Why it needs to be picked
This MR solves the problem for strong compliance based environments where templates would be enforced into pipelines. Currently a POC is done for such a customer where it is vital to have this feature and not wait out until 12.1.
By including this feature into the next patch release we would be able to move forward with that customer. Stronger context can be found in Slack
Alternative would be to have a specific package just for this customer to get the POC started. Based on the risk assesment and the general size of that change I think that it would be better to go with the general patch workflow and get it into 12.0.1.
Potential negative impact of picking
The worst case scenario is the only scenario - we're breaking semver for every single user (both hosted and on-premise) because we are adding a feature into a patch release. This is the primary risk. There might be community backlash as well.
There's a couple of secondary risks as well:
- We're increasing the workload for the delivery team
- We might potentially be increasing the workload for the support team
Release manager sign-off
A release manager (not a trainee) needs to provide initial approval for this exception request.
-
Release manager
Mention others as necessary during discussion.
Sign-off for patch release (delete this section if RC)
Upon initial approval, the release manager will then ping and assign one more role for final approval:
-
One of: - Engineering Manager
- Director of Engineering department
- Senior Director of Development
- Engineering Manager, Quality
- VPE
After approval
Check that the following is accurate before closing this issue:
-
gitlab-org/gitlab-ee!14011 has the correct milestone and label set so that the release managers will pick it. -
gitlab-org/gitlab-ee!14011 has a comment with a link to this issue: - Exception approved in ISSUE_LINK