2018-06-21: 11.0.2 exception request for gitlab-org/gitlab-ce!20075
Exception request
- Merge request to be considered for picking: gitlab-org/gitlab-ce!20075
Why it needs to be picked
This merge requests corrects an incorrect optimization setting for webpack which causes it to neglect to strip out development-mode code. This means that Vue apps will produce verbose warning messages, and other development and test-specific code exists within our production bundles. In effect this causes a performance degradation because:
- extra, unnecessary code is being sent over the network
- extra, unnecessary code is being parsed, compiled, and executed in the browser
It will also produce warning messages in the developer console and potentially muddy our sentry logs.
This is not urgent enough to warrant a 10.8.5 release on its own, but I do think it should be picked into 10-8-stable
so that it would be a part of any future patch release for %10.8.
Potential negative impact of picking
I cannot think of any risks associated with this change.
Release manager sign-off
The release manager needs to provide initial approval for this exception request.
-
Release manager (@filipa or @mayra-cabrera)
Mention others as necessary during discussion.
Sign-off for patch release
Upon initial approval, the release manager will then ping and assign one more role for final approval:
-
Engineering team leader/Engineering department leader/Quality leader/VPE @timzallmann
After approval
Check that the following is accurate before closing this issue:
-
gitlab-org/gitlab-ce!20075 has the correct milestone and label set so that the release managers will pick it. -
gitlab-org/gitlab-ce!20075 has a comment with a link to this issue: - Exception approved in ISSUE_LINK