2018-06-11: 11.0.0.RC8 exception request for gitlab-org/gitlab-ce!19583, gitlab-org/gitlab-ee!6060

Exception request

  • Merge request to be considered for picking: gitlab-org/gitlab-ce!19583 & gitlab-org/gitlab-ee!6060

Why it needs to be picked

Our sign up form is currently not compliant gdpr compliant (https://gitlab.com/gitlab-org/gitlab-ee/issues/6262). We need to add a checkbox to make sure users accept our ToS and Privacy Policy. This is added in aforementioned MRs based on our previous functionality for accepting terms.

Potential negative impact of picking

I think worst case would be users not being able to sign up. To avoid this, automated tests for signing up with the feature are present: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19583/diffs#8cc2b3c38149658145cd3348b6f2429ef3570d16

The changes are also easily tested in staging.

If something were to break, the feature could be turned off in the admin panel until a fix/revert is deployed.

Sign-off

The following need to provide initial approval for this exception request:

If you are the last person to provide initial approval, assign this issue to the VPE for his approval:

After the VPE approves, check that the following is accurate before closing this issue:

  • gitlab-org/gitlab-ce!19583 & gitlab-org/gitlab-ee!6060 have the correct milestone and label set so that the release managers will pick it.
  • gitlab-org/gitlab-ce!19583 & gitlab-org/gitlab-ee!6060 have has a comment with a link to this issue:
Edited by Filipa Lacerda