2018-06-08: 11.0.0.rc7 exception request for gitlab-org/gitlab-ce!19558

Exception request

  • Merge request to be considered for picking: gitlab-org/gitlab-ce!19558

Why it needs to be picked

This fixes a bug found testing the most recent 11.0 RC.

The ability to view CI traces in the web IDE was added in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19279 which will be part of 11.0. Although included in the designs for the feature, the right side bar was fixed width and not resizable. This makes the CI trace pretty much unusable because the you can't even see 80 characters of text.

The exception is for a fix that adds resize capabilities to the right panel of the Web IDE, making the feature usable.

This fix is urgent because we've added a feature that is very useful, we intend to feature in the release post, but is currently not usable in practical situations.

Alternative is not to merge, and release a broken feature, and perhaps include the fix in a patch release. This will mean the feature is broken on GitLab.com for at least two weeks from now until the first patch release after 11.0 is launched.

Potential negative impact of picking

The change only impacts the Web IDE, specifically the right panel which was added in 11.0.

The worst case scenario is that creates a different issue with the right panel. The right panel breaking would not obstruct the ability to change or commit files through the Web IDE.

Usage of the Web IDE is low, but growing every release.

The change is very small, using an existing Vue component for resizable panels that is already used in the Web IDE. It does not change the component.

Sign-off

The following need to provide initial approval for this exception request:

If you are the last person to provide initial approval, assign this issue to the VPE for his approval:

After the VPE approves, check that the following is accurate before closing this issue:

  • gitlab-org/gitlab-ce!19558 has the correct milestone and label set so that the release managers will pick it.
  • gitlab-org/gitlab-ce!19558 has a comment with a link to this issue:
Edited by James Ramsay (ex-GitLab)