Skip to content

Discourage migrations that modify data in sec MRs

John Hope requested to merge jh-migrations-security-mrs into master

See:

Incident gitlab-com/gl-infra/production#6072 (closed) was the result of a data migration gone wrong. It deleted more data than it should have and the recovery process was arduous.

However, this migration was split out from a security MR which originally hid the data correctly. Had the Security MR included the data migration, data recovery would have been more difficult or impossible because of the nature of back-ports and a mid-milestone security release.

This change discourages the use of data migrations entirely Security MRs. Best practice would instead be to hide the offending data in the application layer and follow up with a migration using the regular development process.

Edited by John Hope

Merge request reports