Skip to content
Snippets Groups Projects

Introduce a new CommitAuthor class

Merged Rémy Coutable requested to merge rc/introduce-commit-author into master
All threads resolved!

This will be used in !86 (closed).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @rymai I found it extremely difficult to follow the canonical_name method body, and I think it's a sign that we're bending over backwards to accommodate for a deficiency in the GitLab API. I think we should probably fix the problem there.

    What do you think?

  • assigned to @rymai

  • Author Developer

    I found it extremely difficult to follow the canonical_name method body

    Yeah that's kind of a beast, I can try to improve it.

    I think we should probably fix the problem there.

    @rspeicher Yeah that sounds good, I will investigate that. In the meantime, that'd be great to move forward so that we can get !86 (closed) merged sometimes soon.

  • Rémy Coutable added 1 commit

    added 1 commit

    • 00297d89 - Add httparty to the Gemfile and introduce TeamMember and Team classes

    Compare with previous version

  • Author Developer

    @jameslopez Would you like to review this?

  • Rémy Coutable resolved all discussions

    resolved all discussions

  • Rémy Coutable added 1 commit

    added 1 commit

    • bfee62c5 - Add httparty to the Gemfile and introduce TeamMember and Team classes

    Compare with previous version

  • James Lopez
  • Thanks @rymai! Looks really good. Left a few small comments. Also, the yml files you added to the specs are quite big, do they need to be that huge?

  • assigned to @rymai

  • Rémy Coutable added 2 commits

    added 2 commits

    • c91f2efd - Allow CommitAuthor to take a team and git_names_to_team_names mapping
    • c9379814 - Allow Team#initialize to take an array of members

    Compare with previous version

  • Rémy Coutable resolved all discussions

    resolved all discussions

  • Rémy Coutable added 1 commit

    added 1 commit

    • 15d4da73 - Allow Team#initialize to take an array of members

    Compare with previous version

  • Author Developer

    @jameslopez Thanks for the review, I think I addressed everything!

    Also, the yml files you added to the specs are quite big, do they need to be that huge?

    I've removed it! :tada:

  • @rymai thanks! LGTM :thumbsup: :thumbsup:

  • assigned to @rymai

  • Author Developer

    @smcgivern Care to do a final review since Robert's out? :beach:

  • Author Developer

    @jameslopez Could you please approve, I'd like to move forward here since it's a dependency of !86 (closed).

  • James Lopez approved this merge request

    approved this merge request

  • done! but can't merge.

  • assigned to @rymai

  • merged

  • Sean McGivern mentioned in commit b173f07e

    mentioned in commit b173f07e

  • Author Developer

    @jameslopez @smcgivern Thanks a lot! :heart:

  • Robert Speicher mentioned in merge request !219 (merged)

    mentioned in merge request !219 (merged)

  • Please register or sign in to reply
    Loading