Introduce a new CommitAuthor class
This will be used in !86 (closed).
Merge request reports
Activity
mentioned in merge request !86 (closed)
assigned to @rspeicher
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
@rymai I found it extremely difficult to follow the
canonical_name
method body, and I think it's a sign that we're bending over backwards to accommodate for a deficiency in the GitLab API. I think we should probably fix the problem there.What do you think?
assigned to @rymai
I found it extremely difficult to follow the
canonical_name
method bodyYeah that's kind of a beast, I can try to improve it.
I think we should probably fix the problem there.
@rspeicher Yeah that sounds good, I will investigate that. In the meantime, that'd be great to move forward so that we can get !86 (closed) merged sometimes soon.
added 1 commit
- 00297d89 - Add httparty to the Gemfile and introduce TeamMember and Team classes
@jameslopez Would you like to review this?
assigned to @jameslopez
added 1 commit
- bfee62c5 - Add httparty to the Gemfile and introduce TeamMember and Team classes
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
Thanks @rymai! Looks really good. Left a few small comments. Also, the
yml
files you added to the specs are quite big, do they need to be that huge?assigned to @rymai
added 1 commit
- 15d4da73 - Allow Team#initialize to take an array of members
@jameslopez Thanks for the review, I think I addressed everything!
Also, the
yml
files you added to the specs are quite big, do they need to be that huge?I've removed it!
assigned to @jameslopez
@rymai thanks! LGTM
assigned to @rymai
@smcgivern Care to do a final review since Robert's out?
assigned to @smcgivern
@jameslopez Could you please approve, I'd like to move forward here since it's a dependency of !86 (closed).
assigned to @jameslopez
assigned to @rymai
mentioned in commit b173f07e
@jameslopez @smcgivern Thanks a lot!
mentioned in merge request !219 (merged)