Skip to content

Uses different clientes to validate security merge requests

What does this MR do?

With the security development happening on GitLab, we need to validate security merge requests on Security and Dev remotes, so 'Security::MergeRequestsValidator' was modified to received different security clients.

The architecture was modified in the following way:

  • Security clients were split into Gitlab and Dev
    • Gitlab client re-uses existing code on Security::Client
    • DevClient inherits from GitLabClient
    • The only difference between the clients is the gitlab_client
  • Modifies MergeRequestsValidator to receive a client and to decide which projects_to_verify based on the client.
  • Modifies the security validate rake tasks to call MergeRequestsValidator
    • If security_remote is disabled, it executes MergeRequestsValidator with dev_client only
    • If security_remote is enabled, it executes MergeRequestsValidator with dev_client and Gitlab client

Related to #344

Edited by Mayra Cabrera

Merge request reports