Skip to content

Fix NoMethodError on cherry pick summary message

Robert Speicher requested to merge rs-proper-cherry-pick-fix into master

This merge request reverts 4e4aa045, which was an invalid fix for the original issue at https://gitlab.com/gitlab-org/release-tools/issues/257.

See commit details below.

5a994820 - Revert "Merge branch 'rs-fix-cherry-pick' into 'master'"

This reverts commit 4e4aa045, reversing changes made to 151a4f4e.

cf0eab44 - Use auto_paginate on list of pickable MRs

In reality this shouldn't make a difference, as we don't expect multiple pages of pickable MRs, but this is the "proper" way to do things.

96b2e790 - Add Issuable#project_id

The cherry pick summary was receiving a Gitlab::ObjectifiedHash instance for picked MRs, but a PreparationMergeRequest instance for the summary message. The project_id method existed on the former but not the latter, resulting in a NoMethodError when attempting to post the summary message to the preparation merge request.

Closes https://gitlab.com/gitlab-org/release-tools/issues/259

Edited by Robert Speicher

Merge request reports