Skip to content

Attempt 2: Make some methods in AutoDeploy::Tag class methods

Reuben Pereira requested to merge rp/improve-auto-deploy-tag-interface into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Content

  • Make some methods in AutoDeploy::Tag class methods

Methods that only call other class methods should themselves be class methods.

This changes product_version, component_ref and omnibus_package methods in AutoDeploy::Tag to be class methods.

This also updates callers of those methods, and their specs.

In the first attempt (!3638 (merged)), I missed updating callers of the methods, which resulted in it being reverted due to errors (https://gitlab.com/gitlab-org/release/tasks/-/issues/14709).

Author Check-list

  • Has documentation been updated?
Edited by Reuben Pereira

Merge request reports