Skip to content

Clarify the vars used for testing followup

Mawreen Dela Cruz requested to merge clarify-vars-for-testing-followup into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Following the discussion on the MR about the environment variables that we use for testing, I submitted this MR to further narrow down the environment variables we use to lessen the effort of maintaining too many variables.

Proposal:

  • Retain TEST='true' for dry-runs
  • Use SLACK_TEST='true' for Slack notification testing
  • Temporarily restore IS_TESTING='true' for Slack notification testing but add deprecation notice

I believe this naming convention is pretty straightforward and more specific to the use case, and it can also help prevent confusion.

Content

  • Limit slack notif test var to SLACK_TEST and dry-run var to TEST

Author Check-list

  • Has documentation been updated?
Edited by Mawreen Dela Cruz

Merge request reports