Skip to content
Snippets Groups Projects

Create release environment when tagging release

Merged Dat Tang requested to merge add-release-environment-when-tagging-release into master

What does this MR do and why?

Content

We create one release environment per stable branch, so we want to commit the new environment to the release-environment repo automatically when tagging a new release.

Related to gitlab-com/gl-infra/delivery#19580 (closed)

Note: There is another feature, which is to remove the oldest version. It will be done in a follow up MR.

Tests

See !2876 (comment 1802403317)

Author Check-list

  • [-] Has documentation been updated?
Edited by Mayra Cabrera

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dat Tang requested review from @ahyield and @ggillies

    requested review from @ahyield and @ggillies

  • Contributor
    2 Warnings
    :warning: This merge request is quite big (526 lines changed), please consider splitting it into multiple merge requests.
    :warning: This merge request has more than 20 commits which may cause issues in some of the jobs. If you see errors like missing commits, please consider squashing some commits so it is within 20 commits.

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

    Reviewer Maintainer
    @splattael profile link current availability (UTC+2, same timezone as author) @ahyield profile link current availability (UTC+2, same timezone as author)

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Dat Tang added 1 commit

    added 1 commit

    • 7c7de5e7 - Create release environment when tagging release

    Compare with previous version

  • Dat Tang changed the description

    changed the description

  • I don't know if you want to expand the functionality to also take an optional argument as a specific version to use for the release-environment in cases where the person running the command might not want to use whatever is latest.

    Also, does this work as expected if we create a release-environment for an older release? Will it try and deploy e.g. 15-11-stable with the code from 16-7-stable (or whatever is currently latest)? Perhaps we can't guess for older releases and need the user to specify, or expand how we look for the latest version via what was done on canonical gitlab-org/gitlab itself.

  • Graeme Gillies
  • Mayra Cabrera
  • Dat Tang added 1 commit

    added 1 commit

    • d9f3dba7 - Add release-environment project class

    Compare with previous version

  • Dat Tang added 1 commit

    added 1 commit

    • 47c9f1c3 - Create release environment as a part of the release rake task

    Compare with previous version

  • Dat Tang requested review from @mayra-cabrera

    requested review from @mayra-cabrera

  • Dat Tang added 1 commit

    added 1 commit

    • 86d713ea - Create release environment as a part of the release rake task

    Compare with previous version

  • Dat Tang added 1 commit

    added 1 commit

    • e5eeb074 - Create release environment as a part of the release rake task

    Compare with previous version

  • Dat Tang added 1 commit

    added 1 commit

    • fc5fd237 - Create release environment as a part of the release rake task

    Compare with previous version

  • Dat Tang added 1 commit

    added 1 commit

    • e69e6529 - Create release environment as a part of the release rake task

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading