Upgrade Rubocop gem
What does this MR do and why?
Describe in detail what your merge request does and why.
Content
- Fix failing specs
registry
seems to be a global instance of Rubocop::Cop::Registry. So
I've renamed a variable named registry
so it doesn't clash.
Also fixed a spec in default_branch_literal_spec.rb.
- Use array.push() instead of array.concat([])
Fixes Rubocop Style/ConcatArrayLiterals failures.
- Use each_value instead of each
Fixes Rubocop Style/HashEachMethods failures.
- Fix some rubocop failures
- Fix Style/RedundantParentheses failures
- Fix Layout/ExtraSpacing failures
- Fix Layout/LineContinuationLeadingSpace failure
- Fix Style/RedundantDoubleSplatHashBraces failures
- Fix Style/MapToSet failure
- Fix Style/ArrayIntersect failures
- Fix Style/MinMaxComparison failure
- Remove redundant require to fix Rubocop Lint/RedundantRequireStatement failure
- Return false instead of nil in predicate method
- Remove redundant ::
This fixes the Style/RedundantConstantBase rubocop failures.
- Use anonymous positional arguments forwarding
This fixes Style/ArgumentsForwarding rubocop failures.
- chore(deps): update dependency rubocop to '~> 1.60.0'
Author Check-list
-
Has documentation been updated?